Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Scroll to top keyboard shortcut for splits #3802

Merged
merged 4 commits into from Jun 18, 2022

Conversation

brian6932
Copy link
Contributor

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Added a scroll to top keyboard shortcut, web chat has it, so why shouldn't Chatterino?

Web chat demo
Chatterino demo

zneix
zneix previously requested changes Jun 6, 2022
src/controllers/hotkeys/ActionNames.hpp Show resolved Hide resolved
@brian6932
Copy link
Contributor Author

Yea I did it this way cause it was all sorted alphabetically 🤷

@zneix
Copy link
Collaborator

zneix commented Jun 6, 2022

Another thing is that as we were arguing in chat and you said "you can nav any site with home and end zneix" then I'm sad to break it to you that either with or without this PR you can't scroll to neither top nor bottom of a page of e.g. emote popup or search result popup.
Just pointing that out and saying maybe this PR adds the scrolling mechanism to the wrong scope - maybe it shouldn't belong to this category/scope which it is in currently... but that'd potentially mean Ctrl+End would need to be moved as well.

@brian6932
Copy link
Contributor Author

brian6932 commented Jun 6, 2022

Yea I mean that wasn't really my intention, this is for splits. I'll refine the title and changelog entry to reflect this 👍

@brian6932 brian6932 changed the title Added Scroll to top keyboard shortcut Added a Scroll to top keyboard shortcut for splits Jun 6, 2022
@zneix zneix dismissed their stale review June 6, 2022 14:40

this nitpicking wouldn't achieve anything + my feedback is invalid.

@pajlada pajlada enabled auto-merge (squash) June 18, 2022 11:32
@pajlada pajlada merged commit 9583b49 into Chatterino:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants