Add settings to increase split and usercard scrollback #3811
Conversation
…memory (used for user chatlogs)
|
@goldbattle Have you tested this functionality with more than 1000 messages in a channel? I suspect it would cause crashes before #3798 has been merged in |
|
Seems interesting, just wondering how global search will like 8000+ message look-back in every channel.
Seems to be fine, tested with 1150 messages being render-able, seems the original issue is just loading all of them at once, 800 message history+350 new messages (and 1150 new is fine also). |
|
I tested up to 5k messages for logs with 2k on screen. Works as expected, but the crash with inserting a lot of historical messages is still an issue in this PR. I saw #1421 a couple times when I ran the program. EDIT: I tested searching and it works as expected and is responsive with 6k in the history. |
There was a problem hiding this comment.
The messages_ member of Channel does not need to be a shared_ptr, you just need to initialize it in the constructor (see how name_, type_, lastDate_ and completionModel are initialized in the constructor)
Get your branch up to date with the main branch since we've changed a lot of the LimitedQueue
|
Any updates on what is blocking this? |
|
clang-tidy review says "All clean, LGTM! 👍" |
Code looks fine, I need to test this out a bit |
|
Just want to re-ping on this one. Don't want it to get too far behind and have to keep it up to master. Let me know what I need to do. |
|
clang-tidy review says "All clean, LGTM! 👍" |
UserInfoPopup is now responsible for creating a ChannelView with the correct message limit Split is now responsible for creating a ChannelView with the correct message limit The logic has been moved one step out to ensure we don't change the logic for things like the emote popup
Also changes the step from 1000 to 100
There was a problem hiding this comment.
Changes look good to me now, I'd just like a final review from you @goldbattle to ensure it solves for your issues
My commits should be fairly well-organized to read through, but in short I have:
- Split up & reworded the changelog entries
- Ensured the ChannelView's limit is ONLY changed for
Splits andUserInfoPopups (i.e. usercards) - Renamed the settings & all phrasing around it to fit with our glossary
Once you've approved of my changes (or come with feedback) I'd be happy to merge this in.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Looks good to me. I would still recommend that the default chat log is for usercard is increased Right now usercard log history isn't very helpful in streams > 10k viewers. But I am good either way, thanks for the cleanup. |
pajlada
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Currently the problem is that for fast chats, the user popup log history doesn't provide much information since only 1000 messages are kept for each channel (. This of course makes the memory of the program very small, but basically only allows the logs to have the most recent message from a user (instead of messages in the past 5 minutes).
This adds two params to configure how many messages are displayed on-screen
ChannelViewand how many are kept in memory for use in the chat log / searchingChannel.Use of the shared pointer is not ideal, if there is a better way let me know. I didn't dig deep but it errors on me just re-constructing the variable in the constructor (is there a unique pointer someplace in the
LimitedQueue? not sure..).