Add option to display tabs on the right and bottom #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had held off on marking this pull request as ready for review because I wanted to somehow clean up the rendering logic and have some more shared code between each tab location. However, after looking more at the logic I think that making the code shared would make it much more complex for little benefit. So here we are. (Ignore my attempts at trying to rename the branch) |
pajlada
reviewed
Jul 10, 2022
|
Fixed the spacing with buttons and tabs hidden in 791ebc6 |
pajlada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the option to place the notebook tabs on the right and bottom. Also, ignore the incorrect branch name :)
Closes #1930
Related to #3601
Pull request checklist:
CHANGELOG.mdwas updated, if applicable