Fix crash when closing all tabs on macOS #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableFixes a problem introduced in a commit after the most recent release, so a changelog entry shouldn't be needed.
Description
Fixes #3859
As @LosFarmosCTL pointed out in the issue, the crash was introduced in 6599009 due to some nuance in how Splits are focused. This PR changes the two signal
connectcalls to bemanagedConnectcalls.For some reason, changing how Splits were focused led to the Split instance being destructed before an invocation of
ResizingTextEdit::focusLostoccurs. The Signal's mutex would be destructed along with the Signal and Split and acquiring the lock later would fail with an abort (macOS-specific behavior?).