Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pin Usercards to stay open even if it loses focus #3884

Merged
merged 17 commits into from Nov 12, 2022
Merged

Add ability to pin Usercards to stay open even if it loses focus #3884

merged 17 commits into from Nov 12, 2022

Conversation

goldbattle
Copy link
Contributor

@goldbattle goldbattle commented Jul 29, 2022 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This adds a pin button so that user pin cards can be pinned and not closed after clicking off.
It is useful to be able to pin a specific user, but be able to still open and close others quickly.

bandicam.2022-07-29.17-02-44-918.mp4

pajlada
pajlada requested changes Jul 30, 2022
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have an SVG of the resources added, please include them for when we want to scale these features

src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
@goldbattle
Copy link
Contributor Author

If you have an SVG of the resources added, please include them for when we want to scale these features

Unfortunately I just edited a png in GIMP.

goldbattle
goldbattle commented Aug 5, 2022
View reviewed changes
resources/resources_autogenerated.qrc Outdated
<file>buttons/pinDisabledDark.png</file>
<file>buttons/pinDisabledLight.png</file>
<file>buttons/pinEnabled.png</file>
</qresource>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be what happens when adding the resource through qtcreator. Didn't realize there was a script to do this.

@goldbattle goldbattle requested a review from pajlada August 5, 2022 23:59
@jupjohn
Copy link
Contributor

jupjohn commented Aug 6, 2022 •
edited

I've remade the pin assets (slightly different from originals) as PNGs & plain SVGs:

c2_pin_black c2_pin_black
c2_pin_orange c2_pin_orange
c2_pin_white c2_pin_white

Also here's the Inkscape SVG file if anyone wants to mess with it:
c2_pin.svg

@pajlada pajlada changed the title Add ability to pin user popups Add ability to pin individual Usercards to stay open even if it loses focus Aug 6, 2022
pajlada
pajlada requested changes Aug 6, 2022
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small request which isn't anything you've changed: Could you please change the label of the "Automatically close user popup when it loses focus" setting to "Automatically close usercard when it loses focus"?
Thank you!

src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@goldbattle goldbattle requested a review from pajlada August 6, 2022 17:54
@goldbattle
Copy link
Contributor Author

Any updates on what is blocking this? If nothing, I can fix the conflicts so we can merge.

@goldbattle
Copy link
Contributor Author

Just want to re-ping on this one. Don't want it to get too far behind and have to keep it up to master. Let me know what I need to do.

github-actions[bot]
github-actions bot reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
@pajlada pajlada changed the title Add ability to pin individual Usercards to stay open even if it loses focus Add ability to pin Usercards to stay open even if it loses focus Nov 12, 2022
@pajlada pajlada enabled auto-merge (squash) November 12, 2022 12:01
@pajlada
Copy link
Member

pajlada commented Nov 12, 2022

Thank you @goldbattle and sorry for the long review wait ❤️

@pajlada pajlada merged commit 06b28ea into Chatterino:master Nov 12, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@goldbattle goldbattle mentioned this pull request Nov 14, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goldbattle @jupjohn @pajlada