New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make opening threads from a usercard opened with /usercard not crash the client #3905
Make opening threads from a usercard opened with /usercard not crash the client #3905
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this fix
There are some more ways you can crash things if you close the original split etc but that's more of a chatterino issue than this PR issue
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't crash anymore
Actually this still may crash if the split isn't in the main window |
Unable to crash this with popups 2022-08-12.20-34-51.mp4 |
…ommand_not_crash_when_viewing_replies
clang-tidy review says "All clean, LGTM! 👍" |
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
It's a little hacky IMO but it works. Closes #3902.