Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mentions of "You" in timeouts will link to your own user now instead of the user "You" #3922

Merged
merged 5 commits into from Aug 14, 2022
Merged

fix: Mentions of "You" in timeouts will link to your own user now instead of the user "You" #3922

merged 5 commits into from Aug 14, 2022

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Aug 13, 2022 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • When the current user is timed out once no link was added.
  • When the current user is timed out again a link to the user You was added.

@Mm2PL
Copy link
Collaborator

Mm2PL commented Aug 13, 2022 •
edited

How does this handle twitch's stupid display names? Oh wait I'm stupid this is the local user thing

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Aug 13, 2022 •
edited

I just noticed that multiple timeouts will remove all links, I'll try to fix that in this PR as well:

<forsen> timed out <xqc> for 1s => <forsen [link to xqc]> timed out xqc for 1s (2 times)

@pajlada pajlada changed the title fix: link to the current user in timeouts fix: Mentions of "You" in timeouts will link to your own user now instead of the user "You" Aug 14, 2022
@pajlada pajlada enabled auto-merge (squash) August 14, 2022 11:22
@pajlada pajlada disabled auto-merge August 14, 2022 13:34
@pajlada pajlada merged commit 8ea5b49 into Chatterino:master Aug 14, 2022
@Nerixyz Nerixyz deleted the fix/you-usercard branch January 6, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nerixyz @Mm2PL @pajlada