Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate /clear command to Helix API #3994

Merged
merged 11 commits into from Sep 18, 2022

Conversation

aidenwallis
Copy link
Contributor

@aidenwallis aidenwallis commented Sep 17, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Closes Migrate /clear command to Helix API #3962

  • Implemented a new Helix func deleteChatMessages - this can be used for both /delete and /clear commands as they call the same Twitch Helix endpoint under the hood.

  • Adds command handler for /clear, defined as a lambda function as I will come back in a followup PR to hook up the same lambda to /delete too.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/controllers/commands/CommandController.cpp Outdated Show resolved Hide resolved
src/controllers/commands/CommandController.cpp Outdated Show resolved Hide resolved
src/controllers/commands/CommandController.cpp Outdated Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
tests/src/HighlightController.cpp Show resolved Hide resolved
@pajlada
Copy link
Member

pajlada commented Sep 18, 2022

Thanks for your contribution! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the application.

To do so, open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Make sure to read the comments at a top for instructions.

@pajlada pajlada enabled auto-merge (squash) September 18, 2022 11:07
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
@pajlada pajlada merged commit 6e7b4d8 into Chatterino:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate /clear command to Helix API
3 participants