Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate /unban and /untimeout to Helix API #4026

Merged

Conversation

aidenwallis
Copy link
Contributor

@aidenwallis aidenwallis commented Oct 1, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Migrate /unban and /untimeout to the Helix API. Closes #3961 and #3980 . Both of these IRC commands will call the same endpoint, so decided to do them both in one go.

@aidenwallis aidenwallis marked this pull request as ready for review October 1, 2022 04:33
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
tests/src/HighlightController.cpp Show resolved Hide resolved
@pajlada pajlada force-pushed the helix-command-migration/unban-untimeout branch from 56aa4a2 to be858f3 Compare October 1, 2022 14:49
@pajlada pajlada enabled auto-merge (squash) October 1, 2022 14:53
@pajlada pajlada merged commit a275a17 into Chatterino:master Oct 1, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
src/providers/twitch/api/Helix.cpp Show resolved Hide resolved
tests/src/HighlightController.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate /unban command to Helix API
2 participants