Add showInMentions option for Badge Highlights
#4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QtCreator gave me a hexadecimal error and I can't read that
it crashes when u open the settings but progress
[2022-10-2 07:08:00] #pajlada jammehcow: @Felanbird found it, you need to update BadgeHighlightModel's ctor to specify a vector size of 6, not 5 because you've added a column
Felanbird
commented
Oct 2, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This fixes the tests, as the tests did not set ShowInMentions
pajlada
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Adds the
showInMentionsfunctionality for Badge Highlightscc #3374
TODO:
showInMentionsdoes exist https://github.com/Chatterino/chatterino2/actions/runs/3167789604/jobs/5158531044showInMentionstest