Fix chatters recursion not working #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be tested & verified with the `/test-chatters` command
|
Looks good to me
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| auto formatError = [](HelixGetChattersError error, QString message) { | ||
| using Error = HelixGetChattersError; | ||
| auto formatChattersError = [](HelixGetChattersError error, | ||
| QString message) { |
There was a problem hiding this comment.
warning: the parameter 'message' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| QString message) { | |
| const QString& message) { |
|
|
||
| auto twitchChannel = dynamic_cast<TwitchChannel *>(channel.get()); | ||
| this->registerCommand( | ||
| "/chatters", [formatChattersError](const auto &words, auto channel) { |
There was a problem hiding this comment.
warning: parameter 'words' is unused [misc-unused-parameters]
Suggested change
| "/chatters", [formatChattersError](const auto &words, auto channel) { | |
| "/chatters", [formatChattersError](const auto & /*words*/, auto channel) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Can be tested & verified with the
/test-chatterscommand