Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseTheme is no more 馃 #4132

Merged
merged 4 commits into from Nov 10, 2022
Merged

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Nov 10, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Delete BaseTheme.

@Mm2PL Mm2PL requested a review from pajlada November 10, 2022 00:24
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/singletons/Theme.cpp Show resolved Hide resolved
src/singletons/Theme.cpp Show resolved Hide resolved
src/singletons/Theme.cpp Show resolved Hide resolved
src/singletons/Theme.cpp Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) November 10, 2022 08:46
@pajlada pajlada merged commit 3303cdc into master Nov 10, 2022
@pajlada pajlada deleted the chore/basetheme_is_no_more馃 branch November 10, 2022 09:07
@Felanbird Felanbird mentioned this pull request Jan 5, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants