Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes that can occur when selecting/copying text #4153

Merged
merged 7 commits into from Nov 15, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Nov 15, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Change types of selection indices to unsigned
  • Ensure selection indices are within range before attempting to get the selected text
  • Add changelog entry

@pajlada
Copy link
Member Author

pajlada commented Nov 15, 2022

@kornes If you could take a peek that would be nice, to sanity check my fixes

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

CHANGELOG.md Outdated Show resolved Hide resolved
@kornes
Copy link
Contributor

kornes commented Nov 15, 2022

crash appears to be fixed 👍

@pajlada pajlada enabled auto-merge (squash) November 15, 2022 22:42
@pajlada pajlada merged commit 011facc into master Nov 15, 2022
@pajlada pajlada deleted the fix/selection-crash branch November 15, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants