Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /watching channel jumping around #4169

Merged
merged 3 commits into from Nov 20, 2022

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Nov 20, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

When the extension sends multiple messages with the same channel, Chatterino will always set the channel and thus dispatch a channel-changed signal (which causes a re-layout) even if the channel was already set.

Maybe this could be done in IndirectChannel::reset instead?

void IndirectChannel::reset(ChannelPtr channel)
{
assert(this->data_->type != Channel::Type::Direct);
this->data_->channel = std::move(channel);
this->data_->changed.invoke();
}

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada enabled auto-merge (squash) November 20, 2022 15:40
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada merged commit ba4422b into Chatterino:master Nov 20, 2022
@Nerixyz Nerixyz deleted the fix/native-set-channel branch November 20, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants