fix: don't ignore mousePressEvent in SplitInput
#4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Felanbird
reviewed
Nov 21, 2022
Felanbird
reviewed
Nov 21, 2022
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
Felanbird
approved these changes
Nov 21, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
By default, a
QWidgetwill ignore themousePressEvent. Before #3838,SplitInputhad a handler for this event and thus didn't ignore the event. But the PR removed the event handler.This PR adds the handler back, and only calls the parent handler if the input is hidden. This has the effect that the context menu of the
ResizingTextEditis shown again, so that's what I mentioned in the changelog.Fixes #3844.