Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy Shortcut Not Working In Reply Thread Popup #4209

Merged
merged 2 commits into from Dec 3, 2022

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Dec 2, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Previously, pressing CTRL + C would attempt to copy from the original split (→ and its channel view) instead. This PR fixes the bug.

Fixes #4208.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/splits/SplitInput.hpp Outdated Show resolved Hide resolved
src/widgets/splits/SplitInput.hpp Outdated Show resolved Hide resolved
src/widgets/splits/SplitInput.hpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

@sando
Copy link
Contributor

sando commented Dec 3, 2022

Tested, and this fixes #4208, thanks! ❤️

@Felanbird Felanbird enabled auto-merge (squash) December 3, 2022 11:44
@Felanbird Felanbird merged commit 8d4ee72 into Chatterino:master Dec 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

clang-tidy review says "All clean, LGTM! 👍"

@Nerixyz Nerixyz deleted the fix/reply-copy branch December 3, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTRL+C on text selection doesn't work in reply thread window consistently
4 participants