Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow each layered image to retain its own flags #4460

Merged
merged 2 commits into from Mar 19, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Mar 19, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

All emotes in a LayeredEmoteElement now carry additional flags.

Fixes #4459.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/common/FlagsEnum.hpp Show resolved Hide resolved
src/messages/MessageElement.cpp Show resolved Hide resolved
src/messages/MessageElement.cpp Show resolved Hide resolved
src/messages/MessageElement.cpp Show resolved Hide resolved
src/messages/MessageElement.hpp Show resolved Hide resolved
@pajlada pajlada changed the title Add Flags to Zero Width Emotes Allow each layered image to retain its own flags Mar 19, 2023
@pajlada pajlada merged commit a777a22 into Chatterino:master Mar 19, 2023
15 checks passed
@Nerixyz Nerixyz deleted the fix/zero-width-bad-menu branch March 19, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero Width Emotes Can Have Wrong Context Menu Items
2 participants