New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emote & badge tooltips not showing up when thumbnails were hidden #4509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is tricky because the setting name doesn't do what it says it does.
The description of the setting says whether or not to show "emote info, author" etc on hover (i.e. if the tooltip should be shown at all). The setting actually decides whether or not to show an image preview when hovering over an emote or badge, so while this change is fine it's confusing given the naming & description of the setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kornes if you could review the changes I've made that would be great, after that I'll go ahead and merge this in.
In short, the changes I've made are:
- Changed the setting name in the setting page to match its actual functionality
- Changed the setting to use an enum rather than just an int
- Inverted the
isTextOnly
toshowThumbnail
to match the setting's "intent"
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
fixes #4500
PR fixes display of text only tooltips for emotes and badges, according to "Show info on hover" user setting.
other changes:
tooltipWidget->clearEntries()
emotesTooltipPreview
setting next to other emote settings