Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emote & badge tooltips not showing up when thumbnails were hidden #4509

Merged
merged 9 commits into from Apr 8, 2023

Conversation

kornes
Copy link
Contributor

@kornes kornes commented Apr 3, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

fixes #4500

PR fixes display of text only tooltips for emotes and badges, according to "Show info on hover" user setting.

other changes:

  • flattened one if and removed unnecessary tooltipWidget->clearEntries()
  • moved emotesTooltipPreview setting next to other emote settings

@sando
Copy link
Contributor

sando commented Apr 4, 2023

Confirmed this fixes the bug, thanks!

image

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tricky because the setting name doesn't do what it says it does.
The description of the setting says whether or not to show "emote info, author" etc on hover (i.e. if the tooltip should be shown at all). The setting actually decides whether or not to show an image preview when hovering over an emote or badge, so while this change is fine it's confusing given the naming & description of the setting.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kornes if you could review the changes I've made that would be great, after that I'll go ahead and merge this in.

In short, the changes I've made are:

  1. Changed the setting name in the setting page to match its actual functionality
  2. Changed the setting to use an enum rather than just an int
  3. Inverted the isTextOnly to showThumbnail to match the setting's "intent"

@pajlada pajlada changed the title Fix text only tooltips for emotes and badges Fix emote & badge tooltips not showing up when thumbnails were hidden Apr 8, 2023
@pajlada pajlada enabled auto-merge (squash) April 8, 2023 13:38
@pajlada pajlada merged commit 5c55f62 into Chatterino:master Apr 8, 2023
15 checks passed
@kornes kornes deleted the fix_emote-tooltip-hover branch April 8, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge/emote tooltips don't show unless "Always show" is set
4 participants