Split log line generation from message search text #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
reviewed
Aug 4, 2023
|
This still generates duplicate usernames in logs Without this PR: With this PR: |
pajlada
approved these changes
Aug 5, 2023
|
@Mm2PL has mentioned that this will make a change in how usernames are logged; the previous way was to have two spaces if no localized username was found, this PR changes this with my additional commits |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if ((message->flags.has(MessageFlag::ReplyMessage) && | ||
| getSettings()->stripReplyMention) && | ||
| !getSettings()->hideReplyContext) | ||
| { | ||
| qsizetype colonIndex = messageSearchText.indexOf(':'); | ||
| qsizetype colonIndex = messageText.indexOf(':'); |
There was a problem hiding this comment.
warning: variable 'colonIndex' of type 'qsizetype' (aka 'long long') can be declared 'const' [misc-const-correctness]
Suggested change
| qsizetype colonIndex = messageText.indexOf(':'); | |
| qsizetype const colonIndex = messageText.indexOf(':'); |
| if (colonIndex != -1) | ||
| { | ||
| QString rootMessageChatter = | ||
| message->replyThread->root()->loginName; | ||
| messageSearchText.insert(colonIndex + 1, " @" + rootMessageChatter); | ||
| messageText.insert(colonIndex + 1, " @" + rootMessageChatter); |
There was a problem hiding this comment.
warning: narrowing conversion from 'long long' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
messageText.insert(colonIndex + 1, " @" + rootMessageChatter);
^
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
* Split log line generation from message search text * changelog * remove empty space at the beginning of usernames * Move changelog entry --------- Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
* Split log line generation from message search text * changelog * remove empty space at the beginning of usernames * Move changelog entry --------- Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4697
The line string is now generated in logging code and search text isn't used.