refactor: simplify double click selection #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Could you record how to make the bug appear on master? I can't reproduce it |
|
tested on release 2.4.6 (eb8c7f2d) steps:
|
pajlada
changed the title
pajlada
approved these changes
Oct 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selection has 2 modes, single click starts single character matching at cursor move and double click starts whole word matching at cursor move. This PR refactors double click selection to use simpler approach: creates unified selection between hovered word and starting word.
1a0b611 also fixes bug present on master, where double-click selection would move at each new message due to lack of index shifting. This could be separated PR but included it here for easier testing.