Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to change the top-most status of a window #5135

Merged
merged 4 commits into from Feb 4, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jan 28, 2024

Adds a pin button next to the title bar buttons on Windows and in the Notebook on other platforms. If the Always on top setting is on, this allows one to disable the top-most state of the popup. Not sure if this should be behind a setting.

Closes #3360.

chatterino_2024-01-28_22-20-21.mp4

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if this was a right-click option in the notebook/tabs in popups-only, rather than a button. The option should be whether or not to 'override' the current "always on top" setting.
If always on top is enabled, the right-click option would allow you to "un-always-on-top" the popup.
If always on top is disabled, the right-click option would allow you to "always-on-top" the popup

The setting shouldn't save/load, but rather just persist for as long as Chatterino runs.

If the "always on top" setting is changed, the override should be reset.
So if I have "always on top" enabled, and I right-click a popup & set it to not be always-on-top, then change "always on top" from enabled to disabled, then disabled to enabled, all windows, including my popup, should be "always-on-topped"

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick about the phrasing, then I'm happy to merge 👍 Thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
@Nerixyz Nerixyz changed the title feat: add option to pin a popup feat: add option to change the top-most status of a window Feb 4, 2024
@pajlada pajlada enabled auto-merge (squash) February 4, 2024 12:23
@pajlada pajlada merged commit af8eba0 into Chatterino:master Feb 4, 2024
20 checks passed
@Nerixyz Nerixyz deleted the feat/pin-popup branch February 4, 2024 12:33
devJimmyboy pushed a commit to devJimmyboy/chatterino7 that referenced this pull request Feb 11, 2024
…o#5135)

* feat: add option to pin a popup

* chore: add changelog entry

* chore: change changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants