fix: show correct scale factor of images #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Feb 26, 2024
There was a problem hiding this comment.
Not really a bugfix, just a difference in what 1x/2x/3x/4x represents.
Changelog entry could be Minor & something along the lines of "Image links now reflect the scale of the image instead of its internal label" or "Image links now reflect the scale of the image instead of the image host's label"
pajlada
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, images had the static 1x, 2x, and 3x labels. 1x and 2x were correct, while 3x was incorrect (except for 7TV), since these images were four times larger than the original one. This PR updates the labels for the items to be the factor based on the smallest image.
I'll update the 7TV code to use 4x (when available) in another PR (could also do it here if you want).