Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reward.cost reward.id, reward.title filter variables #5275

Merged
merged 5 commits into from
Mar 30, 2024

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Mar 29, 2024

This grows the Message struct by 16 bytes for the shared_ptr.

This adds the following filter variables:

  • reward.title
  • reward.id
  • reward.cost

The use cases include having a separate split for high cost rewards that you don't want to miss, showing only some rewards in chat.

(felanbird): #4882 #4883

@Felanbird
Copy link
Collaborator

Felanbird commented Mar 29, 2024

title works
cost works but probably needs to be an int i see what i did wrong
id works

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested yet but this seems fine to me 👍

@Mm2PL Mm2PL changed the title Add filter support for reward data Add reward.cost reward.id, reward.title filter variables Mar 29, 2024
@pajlada
Copy link
Member

pajlada commented Mar 30, 2024

I have confirmed that all of these filters work as expected 👍 Thank you!

@pajlada pajlada enabled auto-merge (squash) March 30, 2024 11:01
@pajlada pajlada merged commit 69bdac9 into master Mar 30, 2024
17 checks passed
@pajlada pajlada deleted the feature/store_point_reward_for_filters branch March 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants