FFZ emotes no longer work

[Felanbird]

FFZ used to send us API responses as follows //cdn.frankerfacez.com/xddddd without the necessary https:, so we manually added the https: so we could correctly display emotes.

As of a few hours ago, FFZ has resolved this, but unfortunately we did not want this resolved, and as a result chatterino now sends requests to https:https://cdn.frankerfacez.com/xddddd and said requests fail.

chatterino2/src/providers/ffz/FfzBadges.cpp

Lines 70 to 77 in 1dc2bcc

	auto emote = Emote{
	EmoteName{},
	ImageSet{
	Url{QString("https:") + jsonUrls.value("1").toString()},
	Url{QString("https:") + jsonUrls.value("2").toString()},
	Url{QString("https:") +
	jsonUrls.value("4").toString()}},
	Tooltip{jsonBadge.value("title").toString()}, Url{}};

chatterino2/src/providers/ffz/FfzEmotes.cpp

Lines 19 to 29 in 1dc2bcc

	Url getEmoteLink(const QJsonObject &urls, const QString &emoteScale)
	{
	auto emote = urls.value(emoteScale);
	if (emote.isUndefined() || emote.isNull())
	{
	return {""};
	}
	assert(emote.isString());
	return {"https:" + emote.toString()};

[Felanbird]

Fixed in #4432 - when this comment is about 30 minutes old you can get the fix in the latest nightly build, 2.4.2 will probably have to come out tomorrow. 🧘‍♂️

[Felanbird]

2.4.2 is out now https://github.com/Chatterino/chatterino2/releases/tag/v2.4.2