Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform azure rdp_is_exposed_to_the_internet possible incorrect protocol in query #5246

Closed
binarymist opened this issue Apr 26, 2022 · 1 comment · Fixed by #5313
Closed
Assignees
Labels
bug Something isn't working community Community contribution

Comments

@binarymist
Copy link

binarymist commented Apr 26, 2022

Shouldn't this protocol (https://github.com/Checkmarx/kics/blob/master/assets/queries/terraform/azure/rdp_is_exposed_to_the_internet/query.rego#L22) be TCP?

This query also doesn't mention direction. I would assume that only "Inbound" should be positive?

@cxMiguelSilva
Copy link
Collaborator

Hi @binarymist hope you are doing great!
Thank you so much for your input.
Regarding the first question were checking that the protocol is TCP by verifying that it is neither ICMP nor UDP.
Regarding the second question, we have added the check for traffic direction in some of the KICS queries that check for open ports in this PR #5313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community Community contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants