Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masked Secrets - it works but... #5850

Closed
jycamier opened this issue Sep 28, 2022 · 1 comment · Fixed by #5949
Closed

Masked Secrets - it works but... #5850

jycamier opened this issue Sep 28, 2022 · 1 comment · Fixed by #5949
Assignees
@cxMiguelSilva
Labels
bug Something isn't working community Community contribution

Comments

@jycamier
Copy link
Contributor

The Secrets are now masked in the HTML report 🎉🎉🎉 but in the report you display :

  • the line before
  • the concerned line
  • the line after

If the lines before and after are some clear secrets, these secrets are displayed !

image
@jycamier jycamier added bug Something isn't working community Community contribution labels Sep 28, 2022
@cxMiguelSilva cxMiguelSilva mentioned this issue Oct 18, 2022
Merged
@cxMiguelSilva
Copy link
Collaborator

Hi @jycamier hope you are doing great!
I am glad to inform you that this issue is being solved in #5949.
Thank you so much for another great feedback!!

@cxMiguelSilva cxMiguelSilva self-assigned this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cxMiguelSilva cxMiguelSilva

Labels
bug Something isn't working community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(masked_secrets): Mask Secrets in All Vulnerability Preview Checkmarx/kics
2 participants
@jycamier @cxMiguelSilva