Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown dependency #24

Closed
yegorich opened this issue Mar 11, 2020 · 4 comments · Fixed by #25
Closed

markdown dependency #24

yegorich opened this issue Mar 11, 2020 · 4 comments · Fixed by #25

Comments

@yegorich
Copy link
Contributor

markdown will be imported in Cheetah/Filters.py but it is missing as install_requires in setup.py. Is this intentional?

@phdru
Copy link
Member

phdru commented Mar 11, 2020

Yes. It's an optional dependency. If one never uses Markdown filter one never needs to install markdown.

Perhaps that could be improved with extras_require in SetupConfig.py. Would you like to send a pull request?

@yegorich
Copy link
Contributor Author

It will be nasty as long as you don't drop Python 2 support. BTW what are your plans for dropping Python 2?

@phdru
Copy link
Member

phdru commented Mar 11, 2020

It will be nasty as long as you don't drop Python 2 support.

I don't see any problem with Python 2. I use extras_require in many projects. It requires fresh enough pip and setuptools but works with Python 2.7.

BTW what are your plans for dropping Python 2?

Gonna support Python 2.7 for at least a couple of years. More (5-10 years) if possible.

@phdru
Copy link
Member

phdru commented May 16, 2020

I just released Cheetah 3.2.5 with your PR. Sorry it took so long — I was busy fixing builds with Python 3.4, it's currently the most problematic Python version. And it demonstrates how it soon will be with Python 2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants