Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupiter station driver fails to compile #2

Open
grepwood opened this issue Jul 9, 2020 · 3 comments
Open

Jupiter station driver fails to compile #2

grepwood opened this issue Jul 9, 2020 · 3 comments

Comments

@grepwood
Copy link

grepwood commented Jul 9, 2020

In tag 5.7, compiling Jupiter will yield this error:

drivers/net/wireless/ps3jupiter/ps3_jupiter_sta.c:1338:21: error: initialization of ‘void (*)(struct net_device *)’ from incompatible pointer type ‘void (*)(struct net_device *, unsigned int)’ [-Werror=incompatible-pointer-types]
 1338 |  .ndo_tx_timeout  = ps3_jupiter_sta_tx_timeout,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
@CheezeCake
Copy link
Owner

What kernel version are you using?
The ndo_tx_timeout change landed in 5.6: torvalds/linux@0290bd2

@grepwood
Copy link
Author

I'm applying this to sys-kernel/gentoo-sources-5.4.38.

Which branch will be the next LTS after 5.4?

@CheezeCake
Copy link
Owner

I only track the latest upstream kernel, I don't run older versions.

Which branch will be the next LTS after 5.4?

No idea.
I could make a branch for the current LTS and backport the fixes if you are interested. For 5.4.x, it would just mean reverting the ps3_jupiter_sta_tx_timeout change for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants