Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image & video hardware decoding/encoding (hardware DRM, VCN) support #28

Open
VisualEhrmanntraut opened this issue Mar 17, 2023 · 25 comments
Assignees
Labels
Enhancement Improvements or additions to code
Milestone

Comments

@VisualEhrmanntraut
Copy link
Member

VisualEhrmanntraut commented Mar 17, 2023

No description provided.

@VisualEhrmanntraut VisualEhrmanntraut added the Bug Something isn't working label Mar 17, 2023
@VisualEhrmanntraut VisualEhrmanntraut added this to the Version 1.0.0 milestone Mar 17, 2023
@VisualEhrmanntraut VisualEhrmanntraut self-assigned this Mar 17, 2023
@VisualEhrmanntraut VisualEhrmanntraut pinned this issue Apr 10, 2023
@VisualEhrmanntraut VisualEhrmanntraut changed the title DRM not functional AppleGVA not fully functional May 2, 2023
@VisualEhrmanntraut

This comment was marked as outdated.

@ezxpro

This comment was marked as off-topic.

@jalavoui

This comment was marked as off-topic.

@Kanepan
Copy link

Kanepan commented Aug 25, 2023

Can this be fixed? Looking forward to solving this problem, thank you
Sorry, I posted it again

@aleelmaitro

This comment was marked as spam.

@VisualEhrmanntraut
Copy link
Member Author

VisualEhrmanntraut commented Aug 26, 2023

Be patient, I'm the only dev!

@aleelmaitro

This comment was marked as spam.

@aleelmaitro

This comment was marked as resolved.

@AxerErnest19

This comment was marked as resolved.

@aleelmaitro

This comment was marked as resolved.

@aleelmaitro

This comment was marked as spam.

@ChefKissInc ChefKissInc locked and limited conversation to collaborators Aug 27, 2023
@VisualEhrmanntraut
Copy link
Member Author

As the firmware used is correct, and the logic in macOS is correct, and AppleGVA is seemingly almost patched fully, I have no idea what is still up with this. Maybe there is an issue with the rest of the firmware since we don’t replace anything other than VCN.

@VisualEhrmanntraut
Copy link
Member Author

I have unlocked the conversation for discussion of functionality after new firmware injection. Please don't spam with screenshots or asking for EFIs; I will lock it again.

@jalavoui

This comment was marked as spam.

@pokewizardSAM

This comment was marked as off-topic.

@jalavoui

This comment was marked as spam.

@VisualEhrmanntraut
Copy link
Member Author

One issue is that it doesn't change the capability of how much resolution is supported. VCN 1 supports smaller resolution than VCN 2

@VisualEhrmanntraut
Copy link
Member Author

After further analysis the issue is more complicated than just the VA bundle. For instance, the Metal Accelerator Shared User Client which has different platform function indices in X6000 vs X5000. In addition, the "SML" class, which amongst other functions, dictates whether there's SAMU, VCN, VCE, etc. Furthermore, the Video Context class of the accelerator. There might be more I missed in my analysis. Don't know for sure about the dependency of the Accelerator Shared class, but the VA bundle definitely uses it from what I can tell.

@VisualEhrmanntraut VisualEhrmanntraut added the Help wanted Extra attention is needed label Sep 23, 2023
@VisualEhrmanntraut VisualEhrmanntraut changed the title AppleGVA only partially functional Image & Video hardware decoding/encoding is dysfunctional Sep 23, 2023
@aleelmaitro
Copy link

Hello everyone...
I saw the tag that says "Help Wanted"...
I have no knowledge of programming, but I am willing to carry out tests with your proper instruction...
If this is useful to you, then let me know...

@VisualEhrmanntraut
Copy link
Member Author

I have a testing device of my own, lol.

@aleelmaitro

This comment was marked as spam.

@Hotinosin

This comment was marked as spam.

@VisualEhrmanntraut
Copy link
Member Author

Existing code has been removed because it's broken. Part of a bigger end goal called "The Update".

@VisualEhrmanntraut VisualEhrmanntraut changed the title Image & Video hardware decoding/encoding is dysfunctional Image & video hardware decoding/encoding (hardware DRM, VCN) Mar 14, 2024
@VisualEhrmanntraut VisualEhrmanntraut added Enhancement Improvements or additions to code and removed Bug Something isn't working Help wanted Extra attention is needed labels Mar 14, 2024
@VisualEhrmanntraut VisualEhrmanntraut changed the title Image & video hardware decoding/encoding (hardware DRM, VCN) Image & video hardware decoding/encoding (hardware DRM, VCN) support Mar 14, 2024
@itsyecoder
Copy link

itsyecoder commented Apr 8, 2024

I am using this on an AMD Ryzen 7 5800u. I believe this issue is causing crashes on apps such as Firefox, ultimaker cura, and onedrive. Is there a command to put into boot-arg or anyway to make these apps somewhat useful till this is fixed? (plz mark as off topic)

@ChefKissInc ChefKissInc locked and limited conversation to collaborators Apr 8, 2024
@VisualEhrmanntraut
Copy link
Member Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improvements or additions to code
Projects
Status: 📋 Backlog
Development

No branches or pull requests

9 participants