Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images using the black and white flag without specifying bw #5

Closed
wrightmk opened this issue Aug 28, 2023 · 7 comments
Closed

Images using the black and white flag without specifying bw #5

wrightmk opened this issue Aug 28, 2023 · 7 comments

Comments

@wrightmk
Copy link

If I run the command, stone -i ~/<path to image> --debug or explicitly give it the color option, stone -i ~/<path to image> color --debug, my image always appears in the bw folder and has the black and white color palette show up in debug mode. The only colored image I was able to get to work was the lena image from here http://www.lenna.org/. Any thoughts on what I'm doing wrong? Aside from that, great project!

@ChenglongMa
Copy link
Owner

Hi @wrightmk, thanks for your kind words!

It looks like the app has identified the image you want to process as a black and white image.
If you want to specify the image type manully, you can do the following:

stone -i ~/<path to image> --debug -t color

Or

stone -i ~/<path to image> --debug --image_type color

Please let me know if it still doesn't work.

Thanks!

@wrightmk
Copy link
Author

The above commands still seem to classify the image using the black-and-white method. Here's a screenshot of the command I ran and the output. I also was meaning to mention that the --debug flag will hang at 0%. It still opens up the results window and just hangs in the command line.

Screenshot 2023-08-28 at 2 30 40 PM

@ChenglongMa
Copy link
Owner

Hi @wrightmk, thanks for your feedback.

It's indeed a bug that the app cannot recognize the image_type option. I will fix it today.

The process bar hangs at 0% because the result window is still open. It will reach 100% if you close the window.
PS: The result window will pop up when only one image is processed.

@ChenglongMa
Copy link
Owner

Hi @wrightmk. I've fixed the bug and released the new version.
Please run

pip install skin-tone-classifier --upgrade

to upgrade the library to the latest version.

Thanks again for your feedback.

@wrightmk
Copy link
Author

Hi @ChenglongMa, thanks for addressing this! Works as intended now!

Hi @wrightmk, thanks for your feedback.

It's indeed a bug that the app cannot recognize the image_type option. I will fix it today.

The process bar hangs at 0% because the result window is still open. It will reach 100% if you close the window. PS: The result window will pop up when only one image is processed.

In Response to the process bar hanging, there is no ability to close the window. If you see my screenshot above, there's only window is only able to be minimized (no red dot).

@ChenglongMa
Copy link
Owner

Hi @wrightmk,

I'm glad it is working now :)

You can press any key to close the window whilst the window is in focus.
Please note that if the command line is in focus then nothing happens. (Refer to https://stackoverflow.com/a/28322925/8860079)

@ChenglongMa
Copy link
Owner

Hi @wrightmk,

I will close this issue.
Feel free to reopen it if there are further problems.

Thanks!

Repository owner deleted a comment Mar 6, 2024
Repository owner locked as spam and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants