Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package CI job's Flatpak on Windows forgot to "return 0" when assembly is skipped #317

Open
hollowaykeanho opened this issue Apr 1, 2024 · 1 comment
Assignees
Labels
Bug Case is about a glitch. Done and Pending Release Completed and staging for next release.

Comments

@hollowaykeanho
Copy link
Member

Description

As noted here:

diff --git a/automataCI/_package-flatpak_windows-any.ps1 b/automataCI/_package-flatpak_windows-any.ps1
index 7a38b0e..766e8d5 100644
--- a/automataCI/_package-flatpak_windows-any.ps1
+++ b/automataCI/_package-flatpak_windows-any.ps1
@@ -96,6 +96,7 @@ function PACKAGE-Run-FLATPAK {
        10 {
                $null = I18N-Assemble-Skipped
                $null = FS-Remove-Silently "${_src}"
+               return 0
        } 0 {
                # accepted
        } default {

Expected Behavior

work as expected.

Current Behavior

buggy.

Steps to Reproduce [COMPULSORY]

  1. Create a shell script with any-any naming.
  2. Observe the Flatpak packaging fails.

Associated Data Files

No response

@hollowaykeanho hollowaykeanho added the Bug Case is about a glitch. label Apr 1, 2024
@hollowaykeanho hollowaykeanho self-assigned this Apr 1, 2024
@hollowaykeanho hollowaykeanho added In Progress Someone is working on the case. Done and Pending Release Completed and staging for next release. and removed In Progress Someone is working on the case. labels Apr 1, 2024
@hollowaykeanho
Copy link
Member Author

fixed in 08dc6c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Case is about a glitch. Done and Pending Release Completed and staging for next release.
Projects
Status: v3.0.0
Development

No branches or pull requests

1 participant