Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error viewing expiring Offer notification [Bug] #2175

Closed
danieljperry opened this issue Sep 27, 2023 · 4 comments · Fixed by #2177
Closed

Error viewing expiring Offer notification [Bug] #2175

danieljperry opened this issue Sep 27, 2023 · 4 comments · Fixed by #2177
Assignees
Labels
bug Something isn't working

Comments

@danieljperry
Copy link

danieljperry commented Sep 27, 2023

What happened?

I created an NFT-NFT offer with a standard 7-day expiration. Here is the Offer file:

1_nft1j3rjeyqcahhqjk5sv3ve5p62pcqvpf855tvfxqzhs43cmvnlkg5su0e5p9_x_1_nft19xkl7yrtth6anp55q8zwgpjqewfh556r7at6kxstx3r93vazwj6s9lvgmy.zip

I posted this offer to Dexie, then sent a notification to the owner. From the potential taker's wallet (the wallet that owns nft19xkl7), the notification pops up, and when I click it to view the offer, the GUI crashes with the following error:

notificationerror

Version

2.1.0-rc3 on testnet10

What platform are you using?

Windows

What ui mode are you using?

GUI

Relevant log output or stacktrace

I didn't see any errors in the log.
@danieljperry danieljperry added the bug Something isn't working label Sep 27, 2023
@danieljperry
Copy link
Author

I get the same error on an XCH-for-NFT offer, so it seems likely this is happening because the offer has an expiration time.

@danieljperry
Copy link
Author

Update: the error does not appear with a non-expiring offer notification.

@paninaro
Copy link
Contributor

Thanks for reporting @danieljperry. This was happening because of an incorrect code path when viewing a counterable offer (which is limited to offer notifications).

@paninaro paninaro linked a pull request Sep 27, 2023 that will close this issue
@paninaro
Copy link
Contributor

Fixed in 2.1.0-rc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants