New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rather than copy if tmp2 filename is on the same device as final filename #313

Closed

cross opened this issue Oct 20, 2021 · 14 comments

Labels

Contributor

cross commented Oct 20, 2021

Drawing this over from Chia-Network/chia-blockchain#8847 -

When tmp and final files are in different directories on the same device, the code doesn't know that it can perform a rename(), and instead spends a lot of time unnecessarily copying the file data.

cross mentioned this issue

If tmp2 and final files are in same filesystem, rename() not copy() #314

Merged

Contributor Author

cross commented Oct 24, 2021

PR ready (#314) if/when someone has time to approve it. Thanks.

github-actions bot commented Nov 7, 2021

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

github-actions bot added the stale-issue label

hoffmang9 removed the stale-issue label

github-actions bot commented Nov 22, 2021

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

github-actions bot added the stale-issue label

Contributor Author

cross commented Nov 22, 2021

Not stale, waiting on #314

hoffmang9 removed the stale-issue label

github-actions bot commented Dec 7, 2021

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

github-actions bot added the stale-issue label

Contributor Author

cross commented Dec 7, 2021

Not stale, waiting on #314

hoffmang9 removed the stale-issue label

Contributor Author

cross commented Dec 12, 2021

This is an ongoing irritation in my environment. Can I help in any way getting #314 testing completed so it can be merged?

github-actions bot commented Dec 28, 2021

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

github-actions bot added the stale-issue label

Contributor Author

cross commented Dec 30, 2021

Not stale, still need #314 merged.

hoffmang9 removed the stale-issue label

github-actions bot commented Jan 13, 2022

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

github-actions bot added the stale-issue label

Contributor Author

cross commented Jan 14, 2022

Not stale, still needs merge.

github-actions bot removed the stale-issue label

github-actions bot commented Jan 29, 2022

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

github-actions bot added the stale-issue label

Contributor Author

cross commented Jan 29, 2022

Still waiting. @hoffmang9 , can someone get this in please?

Contributor

wjblanke commented Jan 29, 2022

We'll put this into 1.3 beta so we can get a better idea of how it works in practice with different drives, devices, os, mount point, etc. Need to do another chiapos release then merge into main

wjblanke closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment