New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`get_node_and_wallet_clients` issue #55

Open

kimsk opened this issue Mar 27, 2023 · 0 comments

Assignees

kimsk commented Mar 27, 2023

There was a change from using chia.cmds.wallet_funcs.get_wallet to chia.cmds.cmds_util.get_wallet in ead10ad.

However, the two functions have different signatures:

chia.cmds.wallet_funcs.get_wallet's signature is (wallet_client: WalletRpcClient, fingerprint: int = None) -> Optional[Tuple[WalletRpcClient, int]]
chia.cmds.cmds_util.get_wallet's signature is (root_path: Path, wallet_client: WalletRpcClient, fingerprint: Optional[int]) -> Optional[int].

So the code here doesn't work anymore.

To fix this, we could pass DEFAULT_ROOT_PATH and modify chia.cmds.cmds_util.get_wallet to return WalletRpcClient as well.

The text was updated successfully, but these errors were encountered:

kimsk changed the title ~~get_node_and_wallet_clients issues~~ get_node_and_wallet_clients issue

Quexington self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment