New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔒 🔈 Plug a security vulnerability and alert users to deprecated endpoint #618
Conversation
I would just remove the endpoint, but the mobile app is [still using it](https://github.com/ChildMindInstitute/mindlogger-app/blob/ac4558391236b5bb850125bc1f7bc78369bdc883/app/services/network.js#L141-L156) Resolves #617 Ref #616 on-behalf-of: @ChildMindInstitute <matterlab@childmind.org>
@devbtech Could you test this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shnizzedy There is message, that 'PUT /user/{:id}' is deprecated. But I don't see any implemented methods for changing user information instead of the deprecated method. Is this planned in the future?
@devbtech the idea is that only a user themself could update his/her user info, which would be minimal with most of that information having moved to Profiles. I believe the username and password are the only data that remain in the User object that should be updateable. We already have That last call ( All that is to say, the idea is that the User class be used for authentication but otherwise should not be visible or accessible. |
I would just remove the endpoint, but the mobile app is still using it.
Resolves #617
Ref #616 (comment)