Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Posting responses is using deprecated GET applet?url={url} #50

Open
shnizzedy opened this issue Oct 28, 2019 · 0 comments
Open

⬆ Posting responses is using deprecated GET applet?url={url} #50

shnizzedy opened this issue Oct 28, 2019 · 0 comments

Comments

@shnizzedy
Copy link
Member

@hotavocadoChildMindInstitute/mindlogger-web@8f7078b fixes most of the not-workingness of ML web, but POST response is giving an activity set ID instead of an applet ID because of some deprecated code still in use here. https://github.com/ChildMindInstitute/mindlogger-web/blob/8f7078b093c08fbf079660341ebd611dbc9d0c0f/src/lib/api/api.vue#L138-L149 includes the applet ID, so we shouldn't even be hitting the database again to find it, we just need to clean up the code to use the ID we already have rather than getting the wrong one.

If you run this load-applets branch locally, I think it should work for everything besides saving responses.

@shnizzedy shnizzedy added the bug Something isn't working label Oct 28, 2019
@shnizzedy shnizzedy changed the title ⬆ Posting responses is using deprecated GET applet?url={} ⬆ Posting responses is using deprecated GET applet?url={url} Oct 28, 2019
@shnizzedy shnizzedy added this to To do in MindLogger: EMAs for HBN and NIMH via automation Nov 18, 2019
@shnizzedy shnizzedy added this to To do in MindLogger Demo via automation Nov 18, 2019
@shnizzedy shnizzedy added this to High priority in 🐛 MindLogger Bug Triage Nov 26, 2019
@shnizzedy shnizzedy added help wanted Extra attention is needed small scope web app labels Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants