Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code HC0051 is present twice #5585

Closed
1 task done
kstastny opened this issue Dec 6, 2022 · 2 comments · Fixed by #5623
Closed
1 task done

Error code HC0051 is present twice #5585

kstastny opened this issue Dec 6, 2022 · 2 comments · Fixed by #5623
Labels
🐛 bug Something isn't working 🌶️ hot chocolate
Milestone

Comments

@kstastny
Copy link

kstastny commented Dec 6, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Error Code HC0051 is present twice in error codes

https://github.com/ChilliCream/hotchocolate/blob/main/src/HotChocolate/Core/src/Abstractions/ErrorCodes.cs

Under Schema

        /// <summary>
        /// Type system members are not supported as runtime types
        /// </summary>
        public const string NoSchemaTypesAllowedAsRuntimeType = "HC0051";

and under `Pagination

        /// <summary>
        /// The maximum allowed items per page were exceeded.
        /// </summary>
        public const string MaxPaginationItems = "HC0051";

I expect that the code uniquely identifies the error.

Steps to reproduce

  1. none - please see issue description

Relevant log output

No response

Additional Context?

No response

Product

Hot Chocolate

Version

12.15.2

@kstastny kstastny added the 🐛 bug Something isn't working label Dec 6, 2022
@michaelstaib
Copy link
Member

Yes, that actually is an issue ... at the moment we do a runtime validation but we should move that into the request validation phase. I am adding this to the V13 backlog.

@michaelstaib michaelstaib added 🎉 enhancement New feature or request 🐛 bug Something isn't working and removed 🐛 bug Something isn't working 🎉 enhancement New feature or request labels Dec 19, 2022
@michaelstaib michaelstaib added this to the HC-13.0.0 milestone Dec 19, 2022
@kstastny
Copy link
Author

excellent, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants