Added support to disable subscription on UseGraphQL (#1010)

ChilliCream · Aug 14, 2019 · 56997bb · 56997bb
1 parent 517aae4
commit 56997bb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/src/Server/AspNetCore.Abstractions/QueryMiddlewareOptions.cs b/src/Server/AspNetCore.Abstractions/QueryMiddlewareOptions.cs
@@ -21,9 +21,7 @@ public class QueryMiddlewareOptions
         private PathString _subscriptionPath = new PathString("/");
         private ParserOptions _parserOptions = new ParserOptions();
 
-        [Obsolete(
-            "Use query execution options.",
-            true)]
+        [Obsolete("Use query execution options.", true)]
         public int QueryCacheSize { get; set; } = 100;
 
         public int MaxRequestSize { get; set; } = 20 * 1000 * 1000;
@@ -40,6 +38,7 @@ public ParserOptions ParserOptions
                 _parserOptions = value;
             }
         }
+
         public PathString Path
         {
             get => _path;
@@ -73,6 +72,10 @@ public PathString SubscriptionPath
             }
         }
 
+#if !ASPNETCLASSIC
+        public bool EnableSubscriptions { get; set; } = true;
+#endif
+
         [Obsolete(
             "Use serviceCollection.AddSocketConnectionInterceptor()",
             true)]

diff --git a/src/Server/AspNetCore/Extensions/ApplicationBuilderExtensions.cs b/src/Server/AspNetCore/Extensions/ApplicationBuilderExtensions.cs
@@ -41,7 +41,7 @@ public static class ApplicationBuilderExtensions
                 throw new ArgumentNullException(nameof(options));
             }
 
-            return applicationBuilder
+            applicationBuilder
                 .UseGraphQLHttpPost(new HttpPostMiddlewareOptions
                 {
                     Path = options.Path,
@@ -55,12 +55,19 @@ public static class ApplicationBuilderExtensions
                 .UseGraphQLHttpGetSchema(new HttpGetSchemaMiddlewareOptions
                 {
                     Path = options.Path.Add(new PathString("/schema"))
-                })
-                .UseGraphQLSubscriptions(new SubscriptionMiddlewareOptions
-                {
-                    ParserOptions = options.ParserOptions,
-                    Path = options.SubscriptionPath
                 });
+
+            if (options.EnableSubscriptions)
+            {
+                applicationBuilder.UseGraphQLSubscriptions(
+                    new SubscriptionMiddlewareOptions
+                    {
+                        ParserOptions = options.ParserOptions,
+                        Path = options.SubscriptionPath
+                    });
+            }
+
+            return applicationBuilder;
         }
     }
 }