Added support for non-terminating errors (#249)

ChilliCream · Aug 31, 2018 · a539208 · a539208
1 parent ee40b5f
commit a539208
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 8 deletions.
diff --git a/src/Core/Execution/Errors/QueryException.cs b/src/Core/Execution/Errors/QueryException.cs
@@ -12,32 +12,35 @@ public class QueryException
         public QueryException(string message)
             : base(message)
         {
-            Errors = ImmutableList<IQueryError>.Empty
-                .Add(new QueryError(message));
+            var errors = new List<IQueryError> { new QueryError(message) };
+            Errors = errors.AsReadOnly();
         }
 
         public QueryException(IQueryError error)
         {
             if (error == null)
             {
-                Errors = ImmutableList<IQueryError>.Empty;
+                Errors = Array.Empty<IQueryError>();
             }
             else
             {
-                Errors = ImmutableList<IQueryError>.Empty.Add(error);
+                var errors = new List<IQueryError> { error };
+                Errors = errors.AsReadOnly();
             }
         }
 
         public QueryException(params IQueryError[] errors)
         {
-            Errors = errors?.ToImmutableList()
-                ?? ImmutableList<IQueryError>.Empty;
+            Errors = new List<IQueryError>(
+                errors ?? Array.Empty<IQueryError>())
+                    .AsReadOnly();
         }
 
         public QueryException(IEnumerable<IQueryError> errors)
         {
-            Errors = errors?.ToImmutableList()
-                ?? ImmutableList<IQueryError>.Empty;
+            Errors = new List<IQueryError>(
+               errors ?? Array.Empty<IQueryError>())
+                   .AsReadOnly();
         }
 
         protected QueryException(

diff --git a/src/Core/Execution/ResolverContext.cs b/src/Core/Execution/ResolverContext.cs
@@ -154,5 +154,11 @@ public T Resolver<T>()
         {
             return _executionContext.GetResolver<T>();
         }
+
+        public void ReportError(string errorMessage)
+            => ReportError(new FieldError(errorMessage, FieldSelection));
+
+        public void ReportError(IQueryError error)
+            => _executionContext.ReportError(error);
     }
 }
diff --git a/src/Types/Resolvers/IResolverContext.cs b/src/Types/Resolvers/IResolverContext.cs
@@ -122,5 +122,16 @@ public interface IResolverContext
         /// Returns a resolver object containing one or more resolvers.
         /// </returns>
         T Resolver<T>();
+
+        /// <summary>
+        /// Report a non-terminating resolver error to the execution enhgine.
+        /// The error will be displayed in the errorsection with a reference to
+        /// the field selection that is associated with the current
+        /// resolver context.
+        /// </summary>
+        /// <param name="errorMessage">
+        /// The error message.
+        /// </param>
+        void ReportError(string errorMessage);
     }
 }