Added variable name to all variable errors. (#1423)

ChilliCream · Jan 28, 2020 · dd6a71d · dd6a71d
1 parent 30221a5
commit dd6a71d
Show file tree

Hide file tree

Showing 11 changed files with 22 additions and 14 deletions.
diff --git a/...cution/Middleware/__snapshots__/QueryExecutorTests.ExecuteWithMissingVariables_Error.snap b/...cution/Middleware/__snapshots__/QueryExecutorTests.ExecuteWithMissingVariables_Error.snap
@@ -14,7 +14,7 @@
       ],
       "Exception": null,
       "Extensions": {
-        "variableName": "a",
+        "variable_name": "a",
         "code": "EXEC_NON_NULL_VIOLATION"
       }
     }

diff --git a/...dleware/__snapshots__/QueryExecutorTests.ExecuteWithNonNullVariableInvalidType_Error.snap b/...dleware/__snapshots__/QueryExecutorTests.ExecuteWithNonNullVariableInvalidType_Error.snap
@@ -14,7 +14,8 @@
       ],
       "Exception": null,
       "Extensions": {
-        "code": "EXEC_INVALID_TYPE"
+        "code": "EXEC_INVALID_TYPE",
+        "variable_name": "a"
       }
     }
   ],

diff --git a/...ion/Middleware/__snapshots__/QueryExecutorTests.ExecuteWithNonNullVariableNull_Error.snap b/...ion/Middleware/__snapshots__/QueryExecutorTests.ExecuteWithNonNullVariableNull_Error.snap
@@ -14,7 +14,7 @@
       ],
       "Exception": null,
       "Extensions": {
-        "variableName": "a",
+        "variable_name": "a",
         "code": "EXEC_NON_NULL_VIOLATION"
       }
     }

diff --git a/...Middleware/__snapshots__/QueryExecutorTests.InputObjectVariable_NonNullField_Is_Null.snap b/...Middleware/__snapshots__/QueryExecutorTests.InputObjectVariable_NonNullField_Is_Null.snap
@@ -14,8 +14,8 @@
       ],
       "Exception": null,
       "Extensions": {
-        "variableName": "foo",
-        "variablePath": [
+        "variable_name": "foo",
+        "variable_path": [
           "bar",
           "baz"
         ],

diff --git a/...are/__snapshots__/QueryExecutorTests.InputObject_NonNullField_Has_Variable_With_Null.snap b/...are/__snapshots__/QueryExecutorTests.InputObject_NonNullField_Has_Variable_With_Null.snap
@@ -14,7 +14,7 @@
       ],
       "Exception": null,
       "Extensions": {
-        "variableName": "baz",
+        "variable_name": "baz",
         "code": "EXEC_NON_NULL_VIOLATION"
       }
     }

diff --git a/...Utilities/__snapshots__/VariableValueBuilderTests.Coerce_Variable_Value_Float_To_Int.snap b/...Utilities/__snapshots__/VariableValueBuilderTests.Coerce_Variable_Value_Float_To_Int.snap
@@ -11,7 +11,8 @@
     ],
     "Exception": null,
     "Extensions": {
-      "code": "EXEC_INVALID_TYPE"
+      "code": "EXEC_INVALID_TYPE",
+      "variable_name": "test"
     }
   }
 ]
diff --git a/...tilities/__snapshots__/VariableValueBuilderTests.Coerce_Variable_Value_Int_To_String.snap b/...tilities/__snapshots__/VariableValueBuilderTests.Coerce_Variable_Value_Int_To_String.snap
@@ -11,7 +11,8 @@
     ],
     "Exception": null,
     "Extensions": {
-      "code": "EXEC_INVALID_TYPE"
+      "code": "EXEC_INVALID_TYPE",
+      "variable_name": "test"
     }
   }
 ]
diff --git a/...s/Execution/Utilities/__snapshots__/VariableValueBuilderTests.StringVariableIsObject.snap b/...s/Execution/Utilities/__snapshots__/VariableValueBuilderTests.StringVariableIsObject.snap
@@ -11,7 +11,8 @@
     ],
     "Exception": null,
     "Extensions": {
-      "code": "EXEC_INVALID_TYPE"
+      "code": "EXEC_INVALID_TYPE",
+      "variable_name": "test"
     }
   }
 ]
diff --git a/...tion/__snapshots__/ScalarExecutionErrorTests.InputType_Variable_CannotBeDeserialized.snap b/...tion/__snapshots__/ScalarExecutionErrorTests.InputType_Variable_CannotBeDeserialized.snap
@@ -14,7 +14,8 @@
       ],
       "Exception": null,
       "Extensions": {
-        "code": "EXEC_INVALID_TYPE"
+        "code": "EXEC_INVALID_TYPE",
+        "variable_name": "a"
       }
     }
   ],

diff --git a/src/Core/Core/Execution/Utilities/VariableValueBuilder.cs b/src/Core/Core/Execution/Utilities/VariableValueBuilder.cs
@@ -113,7 +113,7 @@ private Variable CreateVariable(VariableDefinitionNode variableDefinition)
                         variable.Name,
                         TypeVisualizer.Visualize(variable.Type)))
                     .AddLocation(variableDefinition)
-                    .SetExtension("variableName", variable.Name)
+                    .SetExtension("variable_name", variable.Name)
                     .SetCode(ErrorCodes.Execution.NonNullViolation)
                     .Build());
             }
@@ -131,8 +131,8 @@ private Variable CreateVariable(VariableDefinitionNode variableDefinition)
                             TypeResources.VariableValueBuilder_NonNull_In_Graph,
                             variable.Name))
                         .AddLocation(variableDefinition)
-                        .SetExtension("variableName", variable.Name)
-                        .SetExtension("variablePath", report.InputPath)
+                        .SetExtension("variable_name", variable.Name)
+                        .SetExtension("variable_path", report.InputPath)
                         .SetCode(ErrorCodes.Execution.NonNullViolation)
                         .Build());
                 }
@@ -179,6 +179,7 @@ private Variable CreateVariable(VariableDefinitionNode variableDefinition)
                             TypeResources.VariableValueBuilder_InvalidValue,
                             variable.Name))
                         .SetCode(ErrorCodes.Execution.InvalidType)
+                        .SetExtension("variable_name", variable.Name)
                         .AddLocation(variableDefinition)
                         .Build());
                 }
@@ -209,6 +210,7 @@ private Variable CreateVariable(VariableDefinitionNode variableDefinition)
                         TypeResources.VariableValueBuilder_InvalidValue,
                         variable.Name))
                     .SetCode(ErrorCodes.Execution.InvalidType)
+                    .SetExtension("variable_name", variable.Name)
                     .AddLocation(variableDefinition)
                     .Build());
             }
@@ -227,6 +229,7 @@ private Variable CreateVariable(VariableDefinitionNode variableDefinition)
                         TypeResources.VariableValueBuilder_InvalidValue,
                         variable.Name))
                     .SetCode(ErrorCodes.Execution.InvalidType)
+                    .SetExtension("variable_name", variable.Name)
                     .AddLocation(variableDefinition)
                     .Build());
             }

diff --git a/...ore.Tests/__snapshots__/PostMiddlewareTests.HttpPost_Json_Variable_NonNull_Violation.snap b/...ore.Tests/__snapshots__/PostMiddlewareTests.HttpPost_Json_Variable_NonNull_Violation.snap
@@ -10,7 +10,7 @@
         }
       ],
       "extensions": {
-        "variableName": "ep",
+        "variable_name": "ep",
         "code": "EXEC_NON_NULL_VIOLATION"
       }
     }