Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stitching - Requests sent to remote schema with invalid json for variables #2024

Closed
chris-redhead opened this issue Jun 5, 2020 · 1 comment
Assignees

Comments

@chris-redhead
Copy link

Description
When using schema stitching to send requests to a remote resource number variables are not given a trailing comma, therefore producing invalid json.

I've experimented with this and it seems if the remote schema is hotchocolate it will happily parse this invalid json, but other gql implementations won't.

To Reproduce

  1. Set up schema stitching to consume a remote schema.
  2. make a query of the remote schema using one or more number variables (issue exists for ints and floats).
  3. Inspect the body of the http request made - note that number variables are not followed by commas, as they should per json spec.

Expected behavior
valid Json produced.

Additional context
I've put together a fix for this and a test describing the problem. I'll submit a PR

@erwan-joly
Copy link
Contributor

@michaelstaib i think this can now be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants