Mlstubblefield fix/stream closed too early #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalSenn
added
🎨 refactoring
|
First of all, thank you for fixing this. We will include this fix into the next 10.4 hotfix release. For version 11 we are going to rewrite all middlewares completely. |
|
@PascalSenn @rstaib I will bring this into the master and than copy this change over to 10. |
|
@mlstubblefield thanks for contributing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the company I work for, we usually log out the request body if an error has occurred. We do this by reading the respones stream off of the http context in a separate middleware. This isn't possible currently in hotchocolate due to the HttpPostMiddleware closing the stream (arguably when it should not). I made a change so that the stream remains to be open and owned by asp.net.
Happy to build upon this/give more context as needed :)
Also random question, would this impact other middleware handlers in the solution? I did some initial searching, but only found this place where I needed to change it.