Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated tests from GraphQL-JS regarding field merging #1697

Merged
merged 9 commits into from Nov 15, 2020
Merged

Migrated tests from GraphQL-JS regarding field merging #1697

merged 9 commits into from Nov 15, 2020

Conversation

PascalSenn
Copy link
Member

Ports validation tests from GraphQLJs for rule OverlappingFieldsCanBeMergedRule

@PascalSenn PascalSenn self-assigned this Apr 12, 2020
@PascalSenn PascalSenn added 🌶 hot chocolate 🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better. labels Apr 12, 2020
@PascalSenn PascalSenn added this to In progress in Server 11 via automation Apr 12, 2020
@PascalSenn PascalSenn added this to the HC-11.0.0 milestone Apr 12, 2020
@michaelstaib michaelstaib mentioned this pull request Apr 12, 2020
Closed
34 tasks
@PascalSenn PascalSenn linked an issue Apr 19, 2020 that may be closed by this pull request
Migrate graphql-js validation tests. #1633
Closed
34 tasks
@michaelstaib michaelstaib changed the base branch from master to main July 16, 2020 20:12
@michaelstaib michaelstaib changed the base branch from main to develop July 21, 2020 13:36
@michaelstaib michaelstaib changed the base branch from develop to main November 5, 2020 00:47
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit 121cbad into ChilliCream:main Nov 15, 2020
michaelstaib added a commit that referenced this pull request Nov 27, 2020
@PascalSenn @michaelstaib
Migrated tests from GraphQL-JS regarding field merging (#1697)
61dca45 
Co-authored-by: Michael Staib <michael@chillicream.com>
This was referenced Feb 12, 2024
Open
Open
This was referenced Mar 22, 2024
Open
Open
This was referenced Apr 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@PascalSenn PascalSenn

Labels
🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better.
Projects
No open projects
Server 11
  
In progress
Milestone
HC-11.0.0
Development

Successfully merging this pull request may close these issues.

Migrate graphql-js validation tests.
2 participants
@PascalSenn @michaelstaib