Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up as topic is being completed #2016

Merged
merged 1 commit into from Jun 4, 2020
Merged

Clean up as topic is being completed #2016

merged 1 commit into from Jun 4, 2020

Conversation

hognevevle
Copy link

TryRemove instead of TryGetValue when completing topic.

Addresses #2006

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

79.7% 79.7% Coverage
1.4% 1.4% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@michaelstaib michaelstaib merged commit 17226b4 into ChilliCream:version_10_0_0_master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hognevevle @michaelstaib