Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated spatial types to new type system core. #2304

Merged
merged 54 commits into from Oct 4, 2020

Conversation

PascalSenn
Copy link
Member

move to new folder structure

@michaelstaib
Copy link
Member

I will do a quick commit for the build ....

@michaelstaib
Copy link
Member

So, the spatial types are now included into the build and will now again be deployed once this is merged.

@michaelstaib
Copy link
Member

@PascalSenn, regarding namespace, the namespace was correct ...

it is either HotChocolate.Types.Spatial or HotChocolate.Spatial.

Since these are types it should be HotChocolate.Types.Spatial

@michaelstaib
Copy link
Member

PackageId:HotChocolate.Types.Spatial
Namespace: HotChocolate.Types.Spatial

@steveoh
Copy link
Contributor

steveoh commented Sep 10, 2020

I'll wait to review this when the build is passing.

@PascalSenn
Copy link
Member Author

@steveoh @michaelstaib that took a bit longer than expected 🙃
I made a few refactorings and added some resources + documentation, would be nice if you two could have a look at it.

@PascalSenn PascalSenn changed the title WIP: Update spatial types to V11 Update spatial types to V11 Sep 11, 2020
@PascalSenn
Copy link
Member Author

should we reconsider the naming? GeoJson instead of GeoJSON?
every time i use CAPITAL_CASE for abbreviations in the past i ended up with regrets

@michaelstaib michaelstaib changed the title Update spatial types to V11 Migrated spatial types to new type system core. Oct 4, 2020
{
Envelope envelope = geometry.EnvelopeInternal;

// TODO: support Z
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What has to be done here?

@michaelstaib michaelstaib self-requested a review October 4, 2020 19:04
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 64 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit 2497709 into develop Oct 4, 2020
@michaelstaib michaelstaib deleted the pse/spatial-types branch October 4, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants