New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated spatial types to new type system core. #2304
Conversation
I will do a quick commit for the build .... |
So, the spatial types are now included into the build and will now again be deployed once this is merged. |
@PascalSenn, regarding namespace, the namespace was correct ... it is either HotChocolate.Types.Spatial or HotChocolate.Spatial. Since these are types it should be |
PackageId:HotChocolate.Types.Spatial |
I'll wait to review this when the build is passing. |
@steveoh @michaelstaib that took a bit longer than expected 🙃 |
should we reconsider the naming? GeoJson instead of GeoJSON? |
src/HotChocolate/Spatial/src/Types/Extensions/ValueNodeExtensions.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Spatial/src/Types/GeoJSONInputObject.Parsing.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Spatial/src/Types/GeoJSONInputObject.Parsing.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Spatial/test/Types.Tests/GeoJsonLineStringSerializerTests.cs
Show resolved
Hide resolved
src/HotChocolate/Spatial/test/Types.Tests/GeoJsonLineStringSerializerTests.cs
Show resolved
Hide resolved
src/HotChocolate/Spatial/test/Types.Tests/GeoJsonLineStringSerializerTests.cs
Show resolved
Hide resolved
src/HotChocolate/Spatial/test/Types.Tests/GeoJsonLineStringSerializerTests.cs
Show resolved
Hide resolved
src/HotChocolate/Spatial/test/Types.Tests/GeoJsonMultiLineStringTypeTests.cs
Show resolved
Hide resolved
src/HotChocolate/Spatial/test/Types.Tests/GeoJsonMultiLineStringTypeTests.cs
Show resolved
Hide resolved
src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonTypeSerializer.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonLineStringSerializer.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonMultiLineStringSerializer.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonMultiPolygonSerializer.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonPointSerializer.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonPolygonSerializer.cs
Outdated
Show resolved
Hide resolved
…tchocolate into pse/spatial-types
{ | ||
Envelope envelope = geometry.EnvelopeInternal; | ||
|
||
// TODO: support Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What has to be done here?
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
move to new folder structure