Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Apollo Federation Types #2361

Merged
merged 18 commits into from Sep 29, 2020
Merged

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Sep 20, 2020

This PR will add the types needed for Apollo Federation federation.

https://www.apollographql.com/docs/apollo-server/federation/federation-spec/

Part 1 of #1631

@michaelstaib
Copy link
Member Author

@fredericbirke I have updated the draft PR. I started to implement the FieldSet scalar. There are some more tests missing but then it should already work. Next steps would be to add more tests and get the coverage up and bring in more scalar types. We can talk this through on Monday.

@michaelstaib michaelstaib added this to the HC-11.0.0 milestone Sep 20, 2020
@michaelstaib michaelstaib changed the title Apollo Federation Support WIP: Apollo Federation Support Sep 20, 2020
@michaelstaib michaelstaib changed the title WIP: Apollo Federation Support Adds Apollo Federation Types Sep 29, 2020
@michaelstaib michaelstaib added this to review in Backlog Sep 29, 2020
@michaelstaib michaelstaib moved this from review to ready for next preview in Backlog Sep 29, 2020
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

70.8% 70.8% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit db24b42 into develop Sep 29, 2020
@michaelstaib michaelstaib moved this from ready for next preview to current preview in Backlog Sep 29, 2020
@michaelstaib michaelstaib moved this from current preview to Done in Backlog Oct 5, 2020
@michaelstaib michaelstaib deleted the feat-apollo-federation-support branch November 6, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature or request
Projects
No open projects
Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants