Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Filter Binding Tests #2431

Merged
merged 4 commits into from Oct 14, 2020
Merged

Added Filter Binding Tests #2431

merged 4 commits into from Oct 14, 2020

Conversation

PascalSenn
Copy link
Member

Resolves #2092

michaelstaib
michaelstaib previously approved these changes Oct 14, 2020
View reviewed changes
@michaelstaib michaelstaib changed the title add tests for binding Added Filter Binding Tests Oct 14, 2020
@PascalSenn
Copy link
Member Author

@michaelstaib fixed the issue in legacy filtering

@PascalSenn PascalSenn mentioned this pull request Oct 14, 2020
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit d7eba9d into develop Oct 14, 2020
@michaelstaib michaelstaib deleted the pse/add-test-for-implici-binding-filtering branch October 14, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@PascalSenn PascalSenn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UseFiltering() implicit binding doesn't work as intended and ignores type name.
2 participants
@PascalSenn @michaelstaib