Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where empty selection sets lead to execution errors. #2432

Merged
merged 7 commits into from Oct 15, 2020
Merged

Fixed issue where empty selection sets lead to execution errors. #2432

merged 7 commits into from Oct 15, 2020

Conversation

PascalSenn
Copy link
Member

No description provided.

@PascalSenn PascalSenn changed the title WIP: Fix Field Visitor empty selection set Fix Field Visitor empty selection set Oct 14, 2020
@michaelstaib michaelstaib added 🌶 hot chocolate 🐛 bug Something isn't working labels Oct 15, 2020
@michaelstaib michaelstaib changed the title Fix Field Visitor empty selection set Fixed issue where empty selection sets lead to execution errors. Oct 15, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

95.6% 95.6% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit 6d79503 into develop Oct 15, 2020
@michaelstaib michaelstaib deleted the FieldVisitor-allows-empty-selection-set branch October 15, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@PascalSenn PascalSenn

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PascalSenn @michaelstaib