Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error messages for missing conventions #2457

Merged
merged 3 commits into from Oct 18, 2020

Conversation

PascalSenn
Copy link
Member

Changes error message for missing default convention from

No filter convention found for scope `none`

to

No default filter convention found. Call `AddFiltering()` on the schema builder.

and for scope specific error messages from

No filter convention found for scope `Foo`

to

No filter convention found for scope `Foo`. Register a convention with `AddConvention<IFilterConvention, TYourConvention>("Foo")` on the schema builder.

@PascalSenn PascalSenn self-assigned this Oct 17, 2020
@PascalSenn PascalSenn linked an issue Oct 17, 2020 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit a9e91a9 into develop Oct 18, 2020
@michaelstaib michaelstaib deleted the pse/improve-error-messages-for-conventions branch October 18, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter/Sorting Missing Convention Error Message
2 participants