Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed where the stitching query rewriter skipped over variables. #2600

Merged
merged 3 commits into from Nov 18, 2020
Merged

Fixed where the stitching query rewriter skipped over variables. #2600

merged 3 commits into from Nov 18, 2020

Conversation

michaelstaib
Copy link
Member

  • Ensured that the query rewriter also rewrites variables on query directives.
  • Made the result rewriter more robust.

@michaelstaib michaelstaib added this to the HC-11.0.0 milestone Nov 18, 2020
@michaelstaib michaelstaib self-assigned this Nov 18, 2020
@michaelstaib michaelstaib added this to backlog in Backlog via automation Nov 18, 2020
@michaelstaib michaelstaib moved this from backlog to review in Backlog Nov 18, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

72.8% 72.8% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit bec4398 into main Nov 18, 2020
@michaelstaib michaelstaib deleted the mst/stitching-variable-rewriter branch November 18, 2020 10:41
@michaelstaib michaelstaib moved this from review to ready for next preview in Backlog Nov 18, 2020
@michaelstaib michaelstaib moved this from ready for next preview to Done in Backlog Nov 20, 2020
michaelstaib added a commit that referenced this pull request Nov 27, 2020
@michaelstaib
Fixed where the stitching query rewriter skipped over variables. (#2600)
c5c8978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelstaib michaelstaib

Labels
None yet
Projects
No open projects
Backlog
  
Done
Milestone
HC-11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michaelstaib